TestAssertionFailure
: retain full error chain in message
#666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far the conversion from an
Error
to aTestAssertionFailure
meant that all information about the source errors were lost. often, theDisplay
implementation forError
implementations does not include the source information since that should instead be retrieved viasource
. while this has not yet been made into an official API guideline (see rust-lang/api-guidelines#210) this is nevertheless being followed.various crates like
anyhow
oreyere
take care of pretty-printing the error chain on failure, however this does not work withgoogletest
sincegoogletest::Result
hasTestAssertionFailure
as the error type which swallows anyError
and only keeps the message.to resolve this a simple error chain implementation is added to the
From
implementation which pretty-prints the error chain.example:
fixes #657